[Lcdproc] Separate icon area: interface for drivers?

[Markus Dolze]

-------- Original-Nachricht --------
> Datum: Sat, 29 Oct 2011 22:17:33 +0200
> Von: Wolfgang Hauck <wolfgang.hauck at gmx.de>
> An: Stefan Herdler <herdler at gmx.de>, Markus Dolze <bsdfan at nurfuerspam.de>
> CC: lcdproc at lists.omnipotent.net
> Betreff: Re: [Lcdproc] Separate icon area: interface for drivers?

> 
>   * Maintenance of pictogram class enumeration (see attached header file).

Hi,

you should re-think the use of enum for this.

>From my point of view it is not necessary to specify a value to the type. The enum should be just that: an enumeration of the types.

If you don't assign a value to each type then the value will change if someone inserts a new type, but that doesn't matter if only the symbolic names are used (as specified).

You then need no "reserved" values which I think is not a good idea anyway as it will make people use them for "something" to exchange between a client and driver as in the output() function.

There should also be one type "PICT_SW_ALL" to allow turning all on / off at the same time.

Beside this, the list looks fairly complete. Good work!

Regards,
Markus