[Lcdproc] install-server target installs client doco

[Markus Dolze]

Larson, Timothy E. wrote:
> Following are two patches (against 0.5.3) to try to separate installation of doco depending on whether "make install-server" or "make install-clients" is used.  Some of the work had already been done, but looked like it had been left unfinished.  These patches seem to work, but more testing is, of course, appreciated.
>
> However, there are no corresponding uninstall-server/uninstall-clients targets.  I am no expert on makefiles, so I didn't want to go hacking into it myself.  It ought to be fairly simple to someone more knowledge than myself, though.
>
>
> Thanks,
> Tim
>
>
> --- docs/Makefile.am.orig       Sat Jun 20 08:48:34 2009
> +++ docs/Makefile.am    Wed Jan 20 11:57:21 2010
> @@ -1,6 +1,8 @@
>  ## Process this file with automake to produce Makefile.in
>
> -man_MANS = lcdproc.1 lcdexec.1 lcdvc.1 LCDd.8 lcdproc-config.5
> +man1_MANS = lcdproc.1 lcdexec.1 lcdvc.1
> +man5_MANS = lcdproc-config.5
> +man8_MANS = LCDd.8
>  SUBDIRS = lcdproc-user lcdproc-dev
>  doxygen_input = header.html footer.html
>
>
>
>
> --- docs/Makefile.in.orig       Sun Jun 21 10:09:27 2009
> +++ docs/Makefile.in    Wed Jan 20 12:00:16 2010
> @@ -60,7 +60,7 @@
>  man5dir = $(mandir)/man5
>  man8dir = $(mandir)/man8
>  NROFF = nroff
> -MANS = $(man_MANS)
> +MANS = $(man1_MANS) $(man5_MANS) $(man8_MANS)
>  ETAGS = etags
>  CTAGS = ctags
>  DIST_SUBDIRS = $(SUBDIRS)
> @@ -182,7 +182,9 @@
>  sharedstatedir = @sharedstatedir@
>  sysconfdir = @sysconfdir@
>  target_alias = @target_alias@
> -man_MANS = lcdproc.1 lcdexec.1 lcdvc.1 LCDd.8 lcdproc-config.5
> +man1_MANS = lcdproc.1 lcdexec.1 lcdvc.1
> +man5_MANS = lcdproc-config.5
> +man8_MANS = LCDd.8
>  SUBDIRS = lcdproc-user lcdproc-dev
>  doxygen_input = header.html footer.html
>  EXTRA_DIST = lcdproc.1.in \
> _______________________________________________
> LCDproc mailing list
> LCDproc at lists.omnipotent.net
> http://lists.omnipotent.net/mailman/listinfo/lcdproc
>
>   

Hi,

I can't reproduce the problem you describe. Here are my test results:

mmdolze at elenore:test2> make install-server
...
make -C docs install-server-man
test -z "/tmp/test2/share/man/man8" || .././install-sh -c -d
"/tmp/test2/share/man/man8"
 /usr/bin/install -c -m 644 './LCDd.8' '/tmp/test2/share/man/man8/LCDd.8'
test -z "/tmp/test2/share/man/man5" || .././install-sh -c -d
"/tmp/test2/share/man/man5"
 /usr/bin/install -c -m 644 './lcdproc-config.5'
'/tmp/test2/share/man/man5/lcdproc-config.5'

mmdolze at elenore:test2> make install-clients
...
make -C docs install-client-man
test -z "/tmp/test2/share/man/man1" || .././install-sh -c -d
"/tmp/test2/share/man/man1"
 /usr/bin/install -c -m 644 './lcdproc.1'
'/tmp/test2/share/man/man1/lcdproc.1'
 /usr/bin/install -c -m 644 './lcdexec.1'
'/tmp/test2/share/man/man1/lcdexec.1'
 /usr/bin/install -c -m 644 './lcdvc.1' '/tmp/test2/share/man/man1/lcdvc.1'
test -z "/tmp/test2/share/man/man5" || .././install-sh -c -d
"/tmp/test2/share/man/man5"
 /usr/bin/install -c -m 644 './lcdproc-config.5'
'/tmp/test2/share/man/man5/lcdproc-config.5'

For server LCDd.8 and lcdproc-config.5 are installed. For clients
lcdproc.1, lcdexec.1, lcdvc.1, and lcdproc-config.5 are installed.
That's correct.

man_MANS and man#_MANS should have the same result in our case, as we
name the man files by their correct section number (.1 .5 .8).

I don't know why there are no separate uninstall targets, but a 'make
uninstall' suceeds in both cases. On most OS uninstallation is handled
OS specific packaging tools anyway.

Regards,
Markus