[Lcdproc] improved imon hbars
aeriksson2 at fastmail.fm
aeriksson2 at fastmail.fm
Tue Mar 31 17:30:53 UTC 2009
Hi Markus,
Pardon the delay. I've been offline.
bsdfan at nurfuerspam.de said:
> Hi Anders,
> attached you will find a version of your patch that adds the new hBar as an
> optional feature. Looking at my video convinced me to make it on by default.
> Would you please test it? Especially I am interrested if the old behaviour
> could be restored. For this you will have to do:
> export CPPFLAGS="-DIMON_HBARS_OLD"
> ./configure
> make
I checked and it appears to work as expected. However, why do you want to
make this a compile time decision? If it is to be configurable at all, I'd
wote for a runtime config option. What do you expect distros to choose when
they compile it for the masses?
Additionally, the logic tricks my head with the ifNdef of an OLD thing. To me,
it seems more natural if the old cruft stuff is NOT ifdeffed out, and you leave
the "standard" stuff free from ifdefs. But this is just cosmetical.
/Anders
More information about the LCDproc
mailing list