[Lcdproc] [patch] imonlcd backlight option

[William Uther]

Hi all,

   Just joined the mailing list to suggest this small change  
(hopefully before the next release?).  The imonlcd driver recently  
added has a return statement at the front of the imonlcd_backlight()  
function stopping it from doing anything.  The comment in front of it  
reads:

         /*
          * TODO: For some reason, lcdproc keeps calling this and  
flipping the
          * 'on' so you end up flashing the backlight for no  
particular reason
          * (and on my Antec, turning the backlight off, turns the  
whole thing
          * off, so it's really bad...)
          */
	return;

I wanted to turn off my backlight, so I removed that return statement  
to let the function work.  It seems to work just fine for me.  When  
the backlight is off the whole display turns off, but turns back on  
when you turn the backlight back on.  I've been using it that way for  
at least 6 months.

I thought it must have been turned off for a reason however, so rather  
than just remove it I thought it would be better to add an option to  
switch it off.  I'd really like to understand why the return statement  
was originally added.

Anyway, the patch below is pretty self-explanatory.

Be well,

Will          :-}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: lcdproc-imon-backlight.diff
Type: application/octet-stream
Size: 566 bytes
Desc: not available
URL: <http://lists.omnipotent.net/pipermail/lcdproc/attachments/20090606/adbc1f10/attachment.obj>
-------------- next part --------------