[Lcdproc] Big bug in server/main.c

Vallevand, Mark K Mark.Vallevand at UNISYS.com
Tue Feb 24 22:22:42 UTC 2009


Thank you!

Regards.
Mark K Vallevand

"I got free checking at Bear Stearns!"

THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY
MATERIAL and is thus for use only by the intended recipient. If you
received this in error, please contact the sender and delete the e-mail
and its attachments from all computers.


-----Original Message-----
From: Markus Dolze [mailto:bsdfan at nurfuerspam.de] 
Sent: Tuesday, February 24, 2009 4:02 PM
To: Vallevand, Mark K
Cc: lcdproc at lists.omnipotent.net
Subject: Re: [Lcdproc] Big bug in server/main.c

Vallevand, Mark K wrote:
>
> While testing with my embedded Linux and also on SUSE 11 Linux, I 
> found that if time goes backwards, LCDd will stall until time catches 
> up.  Try it.  Set the time back 2 minutes.  For 2 minutes LCDd does 
> nothing.  Here's the fix.
>
>  
>
> server/main.c
>
> 813c813
>
> <                        if ((t_diff + 1) > (LONG_MAX / 1e6)) {
>
> ---
>
> >                        if ( ((t_diff + 1) > (LONG_MAX / 1e6)) || 
> (t_diff<0) ) {
>
> If someone has the time, this really should be rewritten to use 
> something not based on the time and date of Linux.  But, this fix 
> suffices and we are now using it.
>
> Regards.
> Mark K Vallevand
>
Commited, thanks
Markus


More information about the LCDproc mailing list