[Lcdproc] MOU-AL202C-XR

[John Novak]

I have integrated Ray's changes into my LCDProc version and it
functions properly.

Thanks to Ray for the quick, elegant fix and to all for the support.

Best,

On Thu, May 15, 2008 at 10:10 PM, Ethan Dicks <ethan.dicks@gmail.com> wrote:
> On Fri, May 16, 2008 at 5:04 AM, Ray Molenkamp
> <rmolenkamp@matrixorbital.ca> wrote:
>> Ethan Dicks wrote:
>>
>> > I'll have a look at the patch and see how it works with my VKD204, but
>> > from casual inspection, it looks fine.  The only issue I can see is if
>> > the mixed case of "GPOs" conflicts stylistically, or if the name
>> > should be more explicit like "NUM_GPOS" or something similar.
>
>>  NUM_GPOS will be better indeed.
>
> NUM_GPOS it is, then.
>
>>  The assumption thats regular units (LCD/VFD) have 1 and modules with
>> keypads support (LKD/VKD) have 6 might have been true for the 'classic'
>> modules but anything designed or refreshed in the last few years its wrong.
>
> So it appears.
>
>> Thats why I went for the 0 default so it will definitely not go down a wrong
>> code path making it work for all users.
>>
>>  If someone needs the GPOs they consciously need to change the setting and
>> therefore are more likely to know what they are doing and not put a wrong value in
>> there. Even when they do put in a wrong value they'd go "hmm it was working
>> before, its acting up  now must have been something I did to it!"
>>
>>  I'd rather see a setting disabled then wrongly defaulted.
>
> Good point.  A default of zero GPOs is certainly safest.
>
> Thanks for scoping this out.  I'll test this later tonight, and can
> submit a revised patch to the maintainers.
>
> -ethan
>