[Lcdproc] MOU-AL202C-XR

[Ray Molenkamp]

Ethan Dicks wrote:
> I'll have a look at the patch and see how it works with my VKD204, but
> from casual inspection, it looks fine.  The only issue I can see is if
> the mixed case of "GPOs" conflicts stylistically, or if the name
> should be more explicit like "NUM_GPOS" or something similar.  It
> might also make sense to still default to old behavior (1 for LCD/VFD,
> 6 for LKD/VKD) if someone forgets to set the number, since the vast
> majority of models _do_ fit that scheme.
>
> -ethan
>   
NUM_GPOS will be better indeed.

The assumption thats regular units (LCD/VFD) have 1 and modules with 
keypads
support (LKD/VKD) have 6 might have been true for the 'classic' modules 
but anything
designed or refreshed in the last few years its wrong. Thats why I went 
for the
0 default so it will definitely not go down a wrong code path making it 
work for all users.

If someone needs the GPOs they consciously need to change the setting 
and therefore
are more likely to know what they are doing and not put a wrong value in 
there. Even
when they do put in a wrong value they'd go "hmm it was working before, 
its acting up
now must have been something I did to it!"

I'd rather see a setting disabled then wrongly defaulted.

--Ray