[Lcdproc] LCDproc patch for Samsung,20S206DA6 & 20S207DA4

Stefan Herdler herdler@gmx.de
Tue Jan 29 22:06:02 2008


Hi Peter(s),


Peter Marschall wrote:
> Hi Peter,
>
> On Monday, 14. January 2008, Peter Schumann wrote:
>   
>> I've wrote an patch to make the custom characters for the Samsung
>> 20S206DA6 & 20S207DA4 work properly. It's in basic the same as the
>> serialVFD - Futaba type.
>>
>> These displays have 16 user def. chars I had not tried them all but I
>> think is should work.
>>     
>
> thanks for your contribution, but I'd rather not yet add it to the CVS in its 
> current form.
>
> Here are the things I'd like to have fixed before I add them to the CVS:
>
> * Would you mind to try all user def chars?
>   I'd rather be sure things work before releasing them.
>   Especially when I do not have the hardware myself
>   
That wont`t be easy, I think.
The big-numbers are only defined for 6 and 28 user-characters on a 
2-line-display.
Afaik this mode uses the most user-characters.

I would try the "big-clock" mode of the LCDproc-client. If it runs fine, 
I Would say it is o.k. so far.
> * the patch for lines -294,7 +297,7 for serialVFD_displays.c 
>   looks a bit strange as it affects an existing model, while
>   the other parts seem to add a new model.
>   
I guess that is a mistake (it should stay 0x03h), but the rest of the 
patch is looking good, I think.
> * Finally the last one: would you mind to add documentation.
>   Please update the file
>      docs/lcdproc-user/drivers/serialVFD.docbook 
>   and the comments in
>      LCDd.conf
>   accordingly
>
>   
>> Maybe some one add it to the CVS
>>     
> Please see above.
>
> Regards
> PEter
>
>   
Regards
Stefan