[Lcdproc] cwlinux 12832 driver fix

[Peter Marschall]

Hi,

On Tuesday, 2. December 2008, Juanelo wrote:
> Hi, I have been playing with this LCD; to make it work with the current
> CVS driver, I had to edit the file CwLnx.c and add a condition to an if,
> so the following line:
>
> else if (p->model == 12232) {    // the graphical model
>
> i propose to change it to something like:
>
> ...
> else if (p->model==12232 || p->model==12832) {
> ...
> }
> else {
>     printf("CwLnx_set_char(): MODEL %d NOT SUPPORTED!\n", p->model);
>     return;
> }
>
> in both CwLnx_set_char_unrestricted() and CwLnx_set_char()

It is good to see some tests on my extensions that I did
with only the documentation, but with out the hardware.

I added the first part of your patch.
The scond part (the "else { ..." part) is not necessary
as the driver's init function only allows the displays
tested in the "if" and "else if" branches.


> by the way, there is also a #define:
> #define LCD_OFF_CURSOR   72   /* is this correct?*/
>
> that according to the documentation doesn't seem to apply to the 12832
> model; in fact the value "72" has already been defined previously in
> the  same file:
> #define LCD_INIT_INSERT   72 /* go to home */

I know; I wrote this comment as I saw the the collision in the
definition.
But without the hardware I wasn't able to test, so I left it in.

Could you try to test with the line
	CwLnx_hidecursor(p->fd);
commented, and report back whether it still works.

Regards
Peter

-- 
Peter Marschall
peter at adpm.de