[Lcdproc] Calling NetBSD and Darwin developers: Iface fixes

[Peter Marschall]

Hi,

On Saturday, 8. September 2007, Peter Marschall wrote:
> On Sunday, 2. September 2007 23:49, Markus Dolze wrote:
> > while working on the FreeBSD lcdproc client network code, I found a few
> > small errors, which I also fixed for the other two BSD style
> > implementations:
> >
> > 1. If an interface priviously been UP goes DOWN, the time when the
> > interface changed would always show the current time.
> > 2. If an active interface is removed from the system, the server would
> > still show the old screens and the user will not get any notice.
> > 3. The "first run" detection would not work if more than one interface
> > is monitored. Now the "last_online" time is used, because this is an
> > "per interface" value initialized to 0 at startup.
> > 4. The TRUE/FALSE macros are used for the return values as in the other
> > functions.
> >
> > I'm asking myself whether the change 3 is really usefull. Without the
> > change the up / down speed would be shown incorrectly for the first two
> > seconds. Anyway, we do currently not detect counter wraps and resets
> > where this would happen, too.
> >
> > Please test the changes made above!
>
> Since this change looks a bit more intrusive than the one
> I just committed, I will give testers another week to test
> it before I commit it to CVS.
>
> So, Darwin and NetBSD users out there, if you fear this
> patch breaks the lcdproc client, please test and speak up.
>
> If I do not get a negative answer within a week these changes
> will go into LCDproc CVS

I did not get any negative fedback.
In fact I did not get any feedback at all ;-).

So I guess all is fine, and I committed the patch 
to CVS as I announced last week.

Markus thanks angain
Peter

-- 
Peter Marschall
peter@adpm.de