[Lcdproc] [patch] autoconf cleanup
Markus Dolze
bsdfan@nurfuerspam.de
Tue Oct 30 17:43:01 2007
Hello,
for some reason hunk#3 of server/drivers/Makefile.am failed on by CVS
checkout. I have not yet looked into the details why, but corrected the
file manually to get it work.
While I am a friend of making things easier, I have the following comments:
- Lcdproc runs on other platforms than Linux, too. On these pkg-config
may not be available by default (I can only speak for the BSDs) adding
an extra dependency.
- LibFTDI is not a completely portable library. And the shuttfleVFD
driver fails horribly if libftdi is enabled on FreeBSD. So I personally
don't like the idea of enabling it by default (and will disable it for
the package if it is turned on by default).
Regards
Markus
Thomas Jarosch wrote:
> Hello together,
>
> I'm currently developing a new driver for lcdproc which needs libusb and
> libftdi for communication. I took the time to do some cleanup in configure.in
> and the related parts, please have a look. Basically I did the following:
>
> - Switched libftdi/libusb detection to pkgconfig. Pkgconfig has been around
> since 2003 and is much cleaner than large and complex if/else constructs
> in the configure.in script for every library.
>
> - Renamed help string from "--enable-libusb" to "--disable-libusb"
> as it's enabled by default and therefore more intuitive.
> Also use AS_HELP_STRING macro for the formatting.
>
> Please let me know what you think.
>
> Cheers,
> Thomas
>