[Lcdproc] Zalman HD135/VlSys MPlay Blast driver

[Peter Marschall]

Hi,

Wow that was quick !
But did you forget to attach the patch ?

Peter


On Monday, 8. October 2007, you wrote:
> Attached is a patch against current CVS. Fortunately for me my
> previous patch applied with very little difficulty. I've also added
> entries to the LCDd man page & docbook as requested. However, I would
> like to see the fan controller code left in. I intentionally put it
> behind a config flag ('HaveFans') in LCDd.conf so it could be
> disabled if either a) the user didn't want to use the fan controller
> or b) their device didn't support it. I understand that there is no
> simple way to add fan control to the client language, that's why I
> made it a set of config directives so people (like me) who wanted to
> use all the capabilities of their device could get a little closer to
> that goal (you still can't use the remote control feature, but the
> python script I sent previous shows how).
>
> On Oct 8, 2007, at 2:20 AM, Peter Marschall wrote:
> > Hi Sean,
> >
> > On Monday, 8. October 2007, Sean Meiners wrote:
> >> In case anyone is interested, I've written a hd44780 driver for the
> >> display that comes with the Zalman HD135 case (which appears to be a
> >> VlSystem MPlay Blast without the 'keys'). It's very similar to the
> >> lis2 driver with 2 important differences. Its preferred port speed is
> >> 38400 and it uses a rather different method for setting up custom
> >> characters. This display also has two thermal sensors and fan
> >> controllers which I've also enabled via config directives in
> >> LCDd.conf. I haven't tried to get LCDd to publish the temperature or
> >> fan speed data, but you can configure it to do sensible things. The
> >> patch (against 0.5.2) is attached below as well as a python script I
> >> used to help debug the protocol.
> >
> > Although patch looks quite interesting, I currently have a few issues
> > with it that prevent me from adding it to the CVS immediately.
> >
> > 1) It is based against 0.5.2
> >    Would you mind to rebase it against current CVS ?
> >    Should not be too hard I think.
> >
> > 2) It misses documentation.
> >    Would you mind to update the files
> >    - docs/LCDd.8.in
> >    - docs/lcdproc-user/drivers/hd44780.docbook
> >    to tell about the new connection type.
> >    Please see
> >     http://lcdproc.sourceforge.net/docs/current-dev.html#documentation
> >    for a general guideline about docs for new drivers in LCDproc
> >    (since your patch is "only" a ConnectionType for HD44780,
> >     changing the two files above is sufficient.)
> >
> > 3) With the fan control it contains a feature that is very specific
> >    to exactly this hardware and that currently cannot be used with
> >    LCDproc's client language.
> >    In order to keep the driver slim, I suggest having the fan
> > control part
> >    as a separate patch that goes into contrib.
> >
> > With these issues cleared, I think the driver can go int CVS.
> > Thanks in advance for fixing them.
> >
> > Thanks for supporting LCDproc
> > Peter
> >
> > --
> > Peter Marschall
> > peter@adpm.de
> > _______________________________________________
> > LCDproc mailing list
> > LCDproc@lists.omnipotent.net
> > http://lists.omnipotent.net/mailman/listinfo/lcdproc
>
> The person who said it can't be done is always interrupted by the one
> who just did it.



-- 
Peter Marschall
peter@adpm.de