[Lcdproc] curses driver. configurable border.

[Peter Marschall]

Hi Bruno,

On Sunday, 7. October 2007, bruno schwander wrote:
> The border drawn by the curses driver is a waste of space for very
> small terminals, like the 4x40 lcd terminal I have. Here is a diff to
> allow choosing wether the border is drawn or not by specifying
>
> # draw Border [default: yes]
> DrawBorder=no
>
> in the [curses] driver section.
>
> I hope this will be deemed useful and be folded in lcdproc.

although I'd love to have the patch included into LCDproc I
have a few issues with it, that I think you can fix easily:

1) documentation
   Please update 
   - docs/lcdproc-user/drivers/curses.docbook
   - LCDd.conf
   with the new directove for the curses driver
   Pleae see 
http://lcdproc.sourceforge.net/docs/current-dev.html#documentation
   for general guidelines on LCDproc documentation.
    
2) coding style
   Plaese try to adhere to the original coding style in the files
   (i.e. Tabs instead of Spaces, Space after "if" nd before a
   brace opening a block, ...)
   This makes the code more consistent with the rest and makes
   it easier to read (and to grep through ;-)

3) I fear the reduction of the offset in the vbar() and hbar() functions
   is one too much. It reduces the offset and calls chr() afterwards 
   which reduces the offset again.
   Would you mind to check (e.g. with lcdproc client) ?

With these issues fixed the patch will get easily into CVS.
Thanks in advance.

Thanks for supporting LCDproc
Peter

-- 
Peter Marschall
peter@adpm.de