[Lcdproc] Zalman HD135/VlSys MPlay Blast driver

[Peter Marschall]

Hi Sean,

On Monday, 8. October 2007, Sean Meiners wrote:
> In case anyone is interested, I've written a hd44780 driver for the
> display that comes with the Zalman HD135 case (which appears to be a
> VlSystem MPlay Blast without the 'keys'). It's very similar to the
> lis2 driver with 2 important differences. Its preferred port speed is
> 38400 and it uses a rather different method for setting up custom
> characters. This display also has two thermal sensors and fan
> controllers which I've also enabled via config directives in
> LCDd.conf. I haven't tried to get LCDd to publish the temperature or
> fan speed data, but you can configure it to do sensible things. The
> patch (against 0.5.2) is attached below as well as a python script I
> used to help debug the protocol.

Although patch looks quite interesting, I currently have a few issues
with it that prevent me from adding it to the CVS immediately.

1) It is based against 0.5.2
   Would you mind to rebase it against current CVS ?
   Should not be too hard I think.

2) It misses documentation.
   Would you mind to update the files
   - docs/LCDd.8.in
   - docs/lcdproc-user/drivers/hd44780.docbook
   to tell about the new connection type.
   Please see
    http://lcdproc.sourceforge.net/docs/current-dev.html#documentation
   for a general guideline about docs for new drivers in LCDproc
   (since your patch is "only" a ConnectionType for HD44780,
    changing the two files above is sufficient.)
   
3) With the fan control it contains a feature that is very specific
   to exactly this hardware and that currently cannot be used with
   LCDproc's client language.
   In order to keep the driver slim, I suggest having the fan control part
   as a separate patch that goes into contrib.

With these issues cleared, I think the driver can go int CVS.
Thanks in advance for fixing them.

Thanks for supporting LCDproc
Peter

-- 
Peter Marschall
peter@adpm.de