[Lcdproc] lis pthreads patch [was lis driver fails to compile]

Markus Dolze bsdfan@nurfuerspam.de
Tue Nov 6 07:17:01 2007


Daryl F wrote:
> On Mon, 05 Nov 2007 23:26:55 +0100
> Markus Dolze <bsdfan@nurfuerspam.de> wrote:
> 
>> Markus Dolze wrote:
>>> Daryl F wrote:
>>>   
>>>> Peter,
>>>>
>>>> Here's the patch for the lis driver. It now uses pthread_create()
>>>> and is hopefully portable to non-Linux kernels. 
>>>>
>>>> In adding another library test for autoconf I found the logic for
>>>> checking for libftdi and libusb wasn't quite right either. Now it
>>>> checks for all three and ensures that the version of libftdi with
>>>> ftdi_setdtr() is available. This also fixes the minor annoyance of
>>>> configure saying it will build the lis driver twice.
>>>>
>>>> Thanks to Rene Wagner for your help with this.
>>>>
>>>> Regards,
>>>> Daryl
>>>>     
>>> Hello,
>>>
>>> I updated the patch to match current CVS. It compiles fine on
>>> FreeBSD.
>> Hi again,
>>
>> unfortunately I was a little bit too fast. The patch applies cleanly,
>> but the changes to acinclude.m4 don't detect libusb and libftdi
>> properly and therefore the lis driver is not built at all. I think
>> converting it to the pkg-config thing will probably work.
>>
>> Regards
>> Markus Dolze
> 
> Hi Markus,
> 
> Here's the reworked patch using the pkg-config method. I'm concerned
> that it may not detect libpthread. libpthread doesn't use pkg-config.
> Can you try it on FreeBSD and see if it will compile the lis driver?
> 
> Regards,
> Daryl Fonseca-Holt
> 

This time, the driver is really compiles (see smoketest log) after
applying Thomas Jarosch's build fix as well.

Regards
Markus