[Lcdproc] [patch] hd44780 FTDI USB support

[Thomas Jarosch]

--Boundary-00=_Pb1LH6+y2rbiYFu
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Sunday, 4. November 2007, Markus Dolze wrote:
> The hd44780-ftdi driver fails to compile. I think it is because it is
> missing the local includes. However, the config.log shows that
> LIBFTDI_CFLAGS and _LIBS are set correctly.
>
> I really don't understand what autotools are doing here, because e.g.
> for hd44780-lcd2usb (just one line above) the LIBUSB_CFLAGS are set
> correctly. Shouln't the _CFLAGS be the same for all hd44780 drivers?

I'm able to reproduce this if I move ftdi.h somewhere else
and adjust the /usr/lib/pkgconfig/libftdi.pc file accordingly.

For some unknown reason hd44780_CFLAGS is ignored for hd44780-ftdi.c,
only AM_CFLAGS is used. I tried to debug it for a while now and found
the cause of this. The same "problem" is also true for the i2c driver.

Please have a look at the attached patch.

Cheers,
Thomas

--Boundary-00=_Pb1LH6+y2rbiYFu
Content-Type: text/x-diff;
  charset="utf-8";
  name="lcdproc-fix-compile.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="lcdproc-fix-compile.patch"

Index: acinclude.m4
===================================================================
RCS file: /cvsroot/lcdproc/lcdproc/acinclude.m4,v
retrieving revision 1.91
diff -u -r1.91 acinclude.m4
--- acinclude.m4	3 Nov 2007 17:39:06 -0000	1.91
+++ acinclude.m4	5 Nov 2007 17:42:17 -0000
@@ -196,10 +196,10 @@
 				HD44780_DRIVERS="$HD44780_DRIVERS hd44780-hd44780-bwct-usb.o hd44780-hd44780-lcd2usb.o"
 			fi
 			if test "$enable_libftdi" = yes ; then
-				HD44780_DRIVERS="$HD44780_DRIVERS hd44780-ftdi.o"
+				HD44780_DRIVERS="$HD44780_DRIVERS hd44780-hd44780-ftdi.o"
 			fi
 			AC_CHECK_HEADER(linux/i2c-dev.h,
-				HD44780_DRIVERS="$HD44780_DRIVERS hd44780-i2c.o"
+				HD44780_DRIVERS="$HD44780_DRIVERS hd44780-hd44780-i2c.o"
 				AC_DEFINE(HAVE_I2C,[1],[Define to 1 if you have the i2c headers])
 			)
 			DRIVERS="$DRIVERS hd44780${SO}"

--Boundary-00=_Pb1LH6+y2rbiYFu--