[Lcdproc] Fwd: driver for Aopen XC-Cube's VFD display

[Peter Marschall]

Hi Karsten,

On Friday, 9. March 2007 20:07, kafe69@gmx.net wrote:
> since I have an Aopen XC-Cube (see
> http://solution.aopen.com.tw/products/XC/EA65/en/) running MythTV I wanted
> to use the VFD-display on the front. It has only one line with 9
> characters, but it is o.k. for choosing some music to play whithout
> switching on the TV. I found a patch from Kent Williams on the
> gmane.comp.sysutils.lcdproc newsgroup, made some little changes to it and
> now have a patch against the lcdproc CVS from March 4, 2007 attached to
> this mail. Is it possible to integrate it?

Thanks for your contribution to LCDproc.

A few comments though (that currently stop me from adding it to CVS=20
immediately).
* I am missing documentation.
=C2=A0 Without documentation, it is very hard for other users
=C2=A0 to make use of the driver.
=C2=A0 Please see =C2=A0
http://lcdproc.sourceforge.net/docs/current-dev.html#add-your-driver
=C2=A0 and the documentation about existing drivers what I want here.

And a few side notes / questions
* The args argument to the init() function of the drivers is not
  supported anymore. Please consider removing it.
* The driver does not use a private data structure but uses static
  variables. Please consider switching to using a PrivateData *p.
* The driver uses the range [0-255] for its brightness settings.
  The default range for LCDproc drivers is [0-1000]
* The driver does not seem to support custom characters.
=C2=A0 Is it because the hardware does not support them, or is
=C2=A0 is simply because of the (early) driver version ?
* Are you willing to act as a "maintainer" for the driver ?
  And to fix bugs in it, .... ?

Thanks in advance
Peter

=2D-=20
Peter Marschall
peter@adpm.de