Fwd: Re: [Lcdproc] [Lcdproc][patch] Cwlnx driver bug fix

[Peter Marschall]

Hi Gideon,

just a simple follow-up to me previous post.
I tried to optimize a bit the calls to LCD_Write()
in the higher level functions.

Would you mind to test tonight's nightly tar ball ?

Thanks in advance
Peter

----------  Forwarded Message  ----------

Hi Gideon,

On Tuesday, 16. January 2007 11:56, Gideon wrote:
> Thanks for the suggestion.  I worked on it a little bit more.  The loop
> will quit after 30 retries(Would be nice if there are some error
> handling if all fail).   There will be no delay if it writes
> successfully at the first time, but after that the delay helps to keep
> the number of retries smaller. I've tested on both 12232 USB and 1602
> serial, both look fine.

I will commit the changes to CVS.
As for the error handling: patches welcome ;-)))

> I set the "Model" parameter correctly in LCDd.conf, but vertical bar
> didn't draw correctly on 12232 display because there's no mask for the
> graphical mode.  Now the program would still limit 12232 display to draw
> a vertical bar with width 5, but that's the width for all icons.  Any
> other way to do it?

Yes, icons are 5 pixels wide.
But if possible I'd like to make the vertical bars as wide as possible
to make lcdproc's (the client) CPUGraph screen (the one with the "running bar
graph") show as one "block" (i.e. one bar graph instead of X columns
separated by a blank pixel ;-).

How did the bars go wrong with the 12232 ?

Regards
Peter



--
Peter Marschall
peter@adpm.de

-------------------------------------------------------

-- 
Peter Marschall
peter@adpm.de