[Lcdproc] machine_Darwin.c cleanup patch

[Eric Pooch]

As you mentioned, it is just for one system, and I figured there  
would be some performance benefits.  It seems to work fine w/ no leaks.
Frankly, you probably do know better than I do.  It just seemed  
appropriate to use in that function rather than having to do all of  
the cleanup associated with malloc on each error situation.

I'm ambivalent.

--Eric

On Feb 4, 2007, at 12:48 PM, Peter Marschall wrote:


> Hi,
>
> On Sunday, 4. February 2007 19:08, Eric Pooch wrote:
>
>> cleans up some code; uses alloca when possible; enhances comments
>>
>
> applied & committed to CVS.
>
> I am not so sure that using alloca is a good idea in general.
> Here's what the alloca man page in Linux says:
>
> BUGS
>        The alloca() function is machine and compiler dependent. On  
> many
> systems its implementation  is  buggy.
>        Its use is discouraged.
>
>
> In the case of the patch here it is restricted to one special  
> system (Darwin)
> that you know a lot better than I do, so I do trust your judgement.
>
> Thanks
> Peter
>
> -- 
> Peter Marschall
> peter@adpm.de
> _______________________________________________
> LCDproc mailing list
> LCDproc@lists.omnipotent.net
> http://lists.omnipotent.net/mailman/listinfo/lcdproc
>