[Lcdproc] [PATCH] include asm/termbits.h instead of termios.h in hd44780-serial.c

FoX foxcore@gmail.com
Thu Apr 26 19:05:01 2007


2007/4/26, Peter Marschall <peter@adpm.de>:
> As I already wrote in another reply to your post, these patches will not make
> it into LCDproc mainline as they break other configurations.

Hi all, sorry for answering so late but I've been a bit busy these days.

> Would you mind to describe what the exact problem is that these patches are
> trying to solve.

First of all, we use a custom toolchain build from linux kernel
sources + gcc + uClibc.
The kernel headers are installed as every other package : our custom
packages tree.
The install script installs headers in $SYSROOT_PREFIX/usr/include.

>
> Maybe we can come up with a solution that works on all systems.
>
> If it is only the definition of the one baud rate definition (B230400)
> then a simple
>
>         #if defined(B230400)
>          ...
>         #endif
> like for the other hiher baud rates might do the trick.

The configure.in mod by paul_c reveals that my <termios.h>
($SYSROOT_PREFIX/usr/include/termios.h) hasn't the B230400 definition.

Obviously, <asm/termios.h> includes <asm/termbits.h> which hosts B230400.
That's he reason of such a patch.

> If no baud rate is defined in <termios.h> of your tool chain this is
> obviously not enough.
>
> That's why I need more info from you.

I'm also investigate much of my free time on it, and your help is graceful.

> (Just posting a patch with the comment like "fixes compilation with our
> toolchain" and then staying silent at comment to the patch is obviously not
> eneugh either ;-)

The BusyGuy TM

-- 
Guillaume LECERF
GeeXboX developer