[Lcdproc] [PATCH] include asm/termbits.h instead of termios.h in hd44780-serial.c

Peter Marschall peter@adpm.de
Thu Apr 26 17:42:01 2007


Hi,

On Tuesday, 17. April 2007 01:26, FoX wrote:
> This patch fixes compilation of the hd44780 driver with the GeeXbox
> toolchain, by including asm/termbits.h instead of termios.h. This way,
> the baud values definition (i.e. B230400) are resolved correctly.

As I already wrote in another reply to your post, these patches will not make 
it into LCDproc mainline as they break other configurations.

Would you mind to describe what the exact problem is that these patches are 
trying to solve.

Maybe we can come up with a solution that works on all systems.

If it is only the definition of the one baud rate definition (B230400)
then a simple

	#if defined(B230400)
	 ...
	#endif
like for the other hiher baud rates might do the trick.

If no baud rate is defined in <termios.h> of your tool chain this is 
obviously not enough.

That's why I need more info from you.
(Just posting a patch with the comment like "fixes compilation with our 
toolchain" and then staying silent at comment to the patch is obviously not 
eneugh either ;-)

Regards
Peter

-- 
Peter Marschall
peter@adpm.de