[Lcdproc] Re: [PATCH] include asm/termbits.h instead of termios.h in hd44780-serial.c

[Markus Dolze]

Hi,

replacing a header file unconditinally like below will probably brake
the code on other platforms. This happens for sure on *BSD which do not
have asm/termios.h.

A better solution would be to check for the header location in configure
script. Is anyone able to come up with an autotools solution for this?

Regards
Markus Dolze

FoX wrote:
> This version includes <asm/temios.h> instead of <termios.h>. It also
> fixes the compilation with our toolchain and seems less intrusive.
> Chose the best of the two.
> 
> 
> ------------------------------------------------------------------------
> 
> --- lcdproc-0.5.1.orig/server/drivers/hd44780-serial.c	2007-04-17 01:13:17.000000000 +0200
> +++ lcdproc-0.5.1/server/drivers/hd44780-serial.c	2007-04-17 01:13:34.000000000 +0200
> @@ -38,7 +38,7 @@
>  #include <stdio.h>
>  #include <sys/types.h>
>  #include <fcntl.h>
> -#include <termios.h>
> +#include <asm/termios.h>
>  
>  #include <errno.h>
>