[Lcdproc] [patch] Hitachi SP14Q002 added to sed1330 driver

Peter Marschall peter@adpm.de
Sun Dec 31 14:16:01 2006


Hi,

On Friday, 29. December 2006 14:37, Benjamin Wiedmann wrote:
> Hi,
>
> attached is the patch to add functionality for the hitachi sp14q002
> (b/w) display with a resolution of 320 x 240 (w x h) dots.
>
> If possible it would be very nice if you can take this patch and put it
> into the lcdproc source tree so it is usable by anybody without the need
> to do the patching work first.

Added to CSV with one slight change:
WIRING_BITSHAKER is not defined by default to not break 
the build for other users that expect the "classic" connection type.

You can easily define it at compile time by 
  CPPFLAGS=-DWIRING_BITSHAKER ./configure ....

If you feel inclined to hack a bit more on the code,
you may convert this build time -define into a run-time configuration.
Simply:
- convert the defines for A0, nRESET, nWR into variables
  of the PrivateData structure
- get ConnectionType from config file
  see hd44780 how to do it
- set  p->A0, p->nRESET, p->nWR according to the connection type
- change the code that uses A0, nRESET, nWR 
  to p->A0, p->nRESET, p->nWR


> Apply the patch as following:
>
> $ patch -i sed1330.c.diff sed1330.c
Please send in unified diffs (created by diff -u) next time.
They are easier to apply as they contain the names of the file to patch
They even may contain patches for more than one file 


Thanks for helping LCDproc
Peter

-- 
Peter Marschall
peter@adpm.de